[ 
https://issues.apache.org/jira/browse/DRILL-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399333#comment-17399333
 ] 

ASF GitHub Bot commented on DRILL-7984:
---------------------------------------

Leon-WTF commented on pull request #2290:
URL: https://github.com/apache/drill/pull/2290#issuecomment-899033018


   > Thanks much for the contribution! The logic looks right. My comments are 
mostly about the "Drill way" of doing things. Each project has its preferences, 
and I've pointed out Drill's.
   
   Sure, your comments help me to improve a lot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Support Clickhouse using JDBC Storage Plugin
> --------------------------------------------
>
>                 Key: DRILL-7984
>                 URL: https://issues.apache.org/jira/browse/DRILL-7984
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - JDBC
>            Reporter: wtf
>            Assignee: wtf
>            Priority: Major
>
> Trino(Formerly PrestoSQL, branched from Presto) has already supportted 
> [Clickhouse|[https://trino.io/docs/current/connector/clickhouse.html]|https://trino.io/docs/current/connector/clickhouse.html],]
>  using 
> [clickhouse-jdbc|[https://github.com/ClickHouse/clickhouse-jdbc]|https://github.com/ClickHouse/clickhouse-jdbc]
> When connecting to clickhouse using drill jdbc plugin, found one uncompatible 
> place:
> clickhouse-jdbc return constant string "default" when call getCatalogs, and 
> return all databases when call getSchemas(input catalog is not used). All 
> schemas will be appended after the "default" catalog, which will cause the 
> query to fail.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to