[ https://issues.apache.org/jira/browse/DRILL-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523086#comment-17523086 ]
ASF GitHub Bot commented on DRILL-8188: --------------------------------------- luocooong commented on code in PR #2515: URL: https://github.com/apache/drill/pull/2515#discussion_r851623334 ########## contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java: ########## @@ -410,8 +390,22 @@ public boolean next() { return true; } + @Override + public void close() { + AutoCloseables.closeSilently(hdfFile, reader); + /* + * The current implementation of the HDF5 reader creates a temp file which needs to be removed + * when the batch reader is closed. A possible future functionality might be to used to. Review Comment: Done, I added new text for the note. > Convert HDF5 format to EVF2 > --------------------------- > > Key: DRILL-8188 > URL: https://issues.apache.org/jira/browse/DRILL-8188 > Project: Apache Drill > Issue Type: Improvement > Affects Versions: 1.20.0 > Reporter: Cong Luo > Assignee: Cong Luo > Priority: Major > > Use EVF V2 instead of old V1. > Also, fixed a few bugs in V2 framework. -- This message was sent by Atlassian Jira (v8.20.1#820001)