[
https://issues.apache.org/jira/browse/DRILL-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523098#comment-17523098
]
ASF GitHub Bot commented on DRILL-8188:
---------------------------------------
luocooong commented on code in PR #2515:
URL: https://github.com/apache/drill/pull/2515#discussion_r851627022
##########
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/v3/TestScanOuputSchema.java:
##########
@@ -327,4 +375,50 @@ public void
testStrictProvidedSchemaWithWildcardAndSpecialCols() {
assertFalse(scan.next());
scanFixture.close();
}
+
+ @Test
+ public void testProvidedSchemaWithListArray() {
+ TupleMetadata providedSchema = new SchemaBuilder()
+ .add("a", MinorType.INT)
+ .buildSchema();
+
+ BaseScanFixtureBuilder builder = new BaseScanFixtureBuilder(fixture);
+ builder.addReader(negotiator -> new MockSimpleReader(negotiator, true));
+ builder.builder.providedSchema(providedSchema);
+ builder.setProjection(new String[] { "a", "b", "c" });
+ builder.builder.nullType(Types.optional(MinorType.VARCHAR));
+ ScanFixture scanFixture = builder.build();
+ ScanOperatorExec scan = scanFixture.scanOp;
+
+ TupleMetadata expectedSchema = new SchemaBuilder()
+ .add("a", MinorType.INT)
+ .add("b", MinorType.VARCHAR)
+ .add("c", MinorType.VARCHAR)
+ .addRepeatedList("int_list")
+ .addArray(MinorType.INT)
+ .resumeSchema()
+ .addRepeatedList("long_list")
Review Comment:
These tests are to verify the above fix. Is it better to split into a new
test class?
> Convert HDF5 format to EVF2
> ---------------------------
>
> Key: DRILL-8188
> URL: https://issues.apache.org/jira/browse/DRILL-8188
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.20.0
> Reporter: Cong Luo
> Assignee: Cong Luo
> Priority: Major
>
> Use EVF V2 instead of old V1.
> Also, fixed a few bugs in V2 framework.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
