[
https://issues.apache.org/jira/browse/DRILL-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571463#comment-17571463
]
ASF GitHub Bot commented on DRILL-8268:
---------------------------------------
jnturton commented on code in PR #2610:
URL: https://github.com/apache/drill/pull/2610#discussion_r930036634
##########
pom.xml:
##########
@@ -3965,6 +3977,46 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
Review Comment:
My audit of jars that were not present in 1.20.1-hadoop2
#### Comes from Google Sheets plugin
Only in /opt/apache-drill/jars/3rdparty: opencensus-api-0.31.1.jar
Only in /opt/apache-drill/jars/3rdparty:
opencensus-contrib-http-util-0.31.1.jar
Only in /opt/apache-drill/jars/3rdparty: grpc-context-1.27.2.jar
Only in /opt/apache-drill/jars/3rdparty: google-api-client-1.35.2.jar
Only in /opt/apache-drill/jars/3rdparty:
google-api-client-jackson2-1.35.2.jar
Only in /opt/apache-drill/jars/3rdparty:
google-api-services-sheets-v4-rev20220606-1.32.1.jar
Only in /opt/apache-drill/jars/3rdparty:
google-auth-library-credentials-1.8.0.jar
Only in /opt/apache-drill/jars/3rdparty:
google-auth-library-oauth2-http-1.8.0.jar
Only in /opt/apache-drill/jars/3rdparty: google-http-client-1.42.0.jar
Only in /opt/apache-drill/jars/3rdparty:
google-http-client-apache-v2-1.42.0.jar
Only in /opt/apache-drill/jars/3rdparty: google-http-client-gson-1.42.0.jar
Only in /opt/apache-drill/jars/3rdparty: google-oauth-client-1.34.1.jar
Only in /opt/apache-drill/jars/3rdparty: google-oauth-client-java6-1.34.1.jar
Only in /opt/apache-drill/jars/3rdparty: google-oauth-client-jetty-1.34.1.jar
#### Comes from Swagger
Only in /opt/apache-drill/jars/3rdparty: narcissus-1.0.1.jar
Only in /opt/apache-drill/jars/3rdparty: jvm-driver-4.0.0.jar
Only in /opt/apache-drill/jars/3rdparty: classgraph-4.8.117.jar
Only in /opt/apache-drill/jars/3rdparty: swagger-annotations-2.1.12.jar
Only in /opt/apache-drill/jars/3rdparty: swagger-core-2.1.12.jar
Only in /opt/apache-drill/jars/3rdparty: swagger-integration-2.1.12.jar
Only in /opt/apache-drill/jars/3rdparty: swagger-jaxrs2-2.1.12.jar
Only in /opt/apache-drill/jars/3rdparty:
swagger-jaxrs2-servlet-initializer-v2-2.1.12.jar
Only in /opt/apache-drill/jars/3rdparty: swagger-models-2.1.12.jar
#### Looks like nimbus-jose-jwt was downgraded in Hadoop 2, causing this
downgrade
Only in /opt/apache-drill/jars/3rdparty: accessors-smart-1.2.jar
> Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default
> ---------------------------------------------------------------------------
>
> Key: DRILL-8268
> URL: https://issues.apache.org/jira/browse/DRILL-8268
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.20.1
> Reporter: James Turton
> Assignee: James Turton
> Priority: Major
> Fix For: 1.20.2
>
>
> # New exclusions of reload4j, slf4j-reload4j are required in the Hadoop 2
> profile, probably due to the upgrade of Hadoop from 2.10.1 to 2.10.2.
> # We remove the netty-all metapackage which entered the dependency tree with
> the change introducing the Netty bom bringing many uneeded libs with it.
> # The heap memory usage limiting logic in the REST server becomes disabled
> by default since REST query results are streamed these days. This change aims
> to let the Java GC now do its job without interference and if that results in
> OOM under a constant load then there is good evidence for a heap leak which
> must be tracked down and completely resolved anyway, not mitigated or "swept
> under a rug".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
