[
https://issues.apache.org/jira/browse/DRILL-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571521#comment-17571521
]
ASF GitHub Bot commented on DRILL-8268:
---------------------------------------
martin-g commented on PR #2610:
URL: https://github.com/apache/drill/pull/2610#issuecomment-1195684710
Good job, James!
On Tue, Jul 26, 2022, 18:37 James Turton ***@***.***> wrote:
> @luocooong <https://github.com/luocooong> See
> https://stackoverflow.com/a/61267496/497381
> java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer; is not available in
> JDK 1.8. It is available since Java 11. In 1.8 the return type is
> Ljava/nio/Buffer;. I am not sure why Github CI / Main Build (8) passes.
> Maybe it does not cover this code path ?!
>
> @martin-g <https://github.com/martin-g> thanks for looking into it, we've
> progressed to a successful build now. I was dragging in bad dependencies
> and somehow, specifically for aarch64, that seems to have caused a jar
> compiled with a >8 JDK, probably Netty, to have been pulled in to the
> Travis JDK 8 environment. That's my suspicion, anyway.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/drill/pull/2610#issuecomment-1195642829>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AABYUQQ54KHMPPSGE74NRXTVWAA2XANCNFSM54LVHSKQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
> Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default
> ---------------------------------------------------------------------------
>
> Key: DRILL-8268
> URL: https://issues.apache.org/jira/browse/DRILL-8268
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.20.1
> Reporter: James Turton
> Assignee: James Turton
> Priority: Major
> Fix For: 1.20.2
>
>
> # New exclusions of reload4j, slf4j-reload4j are required in the Hadoop 2
> profile, probably due to the upgrade of Hadoop from 2.10.1 to 2.10.2.
> # We remove the netty-all metapackage which entered the dependency tree with
> the change introducing the Netty bom bringing many uneeded libs with it.
> # The heap memory usage limiting logic in the REST server becomes disabled
> by default since REST query results are streamed these days. This change aims
> to let the Java GC now do its job without interference and if that results in
> OOM under a constant load then there is good evidence for a heap leak which
> must be tracked down and completely resolved anyway, not mitigated or "swept
> under a rug".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
