[
https://issues.apache.org/jira/browse/DRILL-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625649#comment-17625649
]
ASF GitHub Bot commented on DRILL-8345:
---------------------------------------
jnturton commented on PR #2694:
URL: https://github.com/apache/drill/pull/2694#issuecomment-1294911988
> @jnturton, there are also other places where this variable is used. Should
similar changes also be made there?
@vvysotskyi ah, thanks I'll see if I can change the other two.
> Fix Eclipse compatibility in the Maven resources plugin config
> --------------------------------------------------------------
>
> Key: DRILL-8345
> URL: https://issues.apache.org/jira/browse/DRILL-8345
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Affects Versions: 1.20.2
> Reporter: James Turton
> Assignee: James Turton
> Priority: Minor
> Fix For: 1.20.3
>
>
> The Maven resources plugin config in /pom.xml makes use of the undocumented
> variable maven.multiModuleProjectDirectory to copy /git.properties to
> target/classes in every sub-module. This variable breaks the project build in
> Eclipse 2022-03, even when a .mvn directory is present at the project root,
> and was probably never meant for use by the public. Replacing it with the
> session.executionRootDirectory Maven variable fixes the build in Eclipse and
> retains the intended copying of git.properties during builds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
