[
https://issues.apache.org/jira/browse/DRILL-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626005#comment-17626005
]
ASF GitHub Bot commented on DRILL-8345:
---------------------------------------
jnturton commented on PR #2694:
URL: https://github.com/apache/drill/pull/2694#issuecomment-1295741674
Firstly, the other occurrences of maven.multiModuleProjectDirectory cannot
be changed session.executionRootDirectory without causing issues and secondly
the Eclipse problems I'd run into were due to my recent version of Eclipse
holding onto a very old version of m2e, probably from a previous installation
long ago. After purging Eclipse completely and reinstalling I've found that
there is no longer any need for pom changes to make Drill build in Eclipse.
> Fix Eclipse compatibility in the Maven resources plugin config
> --------------------------------------------------------------
>
> Key: DRILL-8345
> URL: https://issues.apache.org/jira/browse/DRILL-8345
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Affects Versions: 1.20.2
> Reporter: James Turton
> Assignee: James Turton
> Priority: Minor
> Fix For: 1.20.3
>
>
> The Maven resources plugin config in /pom.xml makes use of the undocumented
> variable maven.multiModuleProjectDirectory to copy /git.properties to
> target/classes in every sub-module. This variable breaks the project build in
> Eclipse 2022-03, even when a .mvn directory is present at the project root,
> and was probably never meant for use by the public. Replacing it with the
> session.executionRootDirectory Maven variable fixes the build in Eclipse and
> retains the intended copying of git.properties during builds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
