[
https://issues.apache.org/jira/browse/DRILL-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713048#comment-17713048
]
ASF GitHub Bot commented on DRILL-8424:
---------------------------------------
jnturton opened a new pull request, #2794:
URL: https://github.com/apache/drill/pull/2794
# [DRILL-8424](https://issues.apache.org/jira/browse/DRILL-8424):
Accommodate RexBuilder changes made for SAFE_CAST
## Description
Resolves the current CI test failues affecting decimal and
empty-literal-to-null casting. Also incorporates upstream syntax additions in
Drill's Parser.jj which can only be dropped when
[CALCITE-5579](https://issues.apache.org/jira/browse/CALCITE-5579) is resolved.
* Incorporate method signature changes in RexBuilder made by CALCITE-5557.
* Fix float rounding error in TestCastFunctions.testCastFloatDecimalOverflow.
* Incorporate Calcite parser changes.
* [CALCITE-5557] Add SAFE_CAST function (enabled in BigQuery library)
* [CALCITE-5548] Add MSSQL-style CONVERT function (enabled in MSSql
library)
* [CALCITE-5554] In EXTRACT function, add DAYOFWEEK and DAYOFYEAR as
synonyms for DOW, DOY
* Ignore .mvn/maven.config.
* Upgrade Apache RAT plugin.
* Upgrade os-maven-plugin.
* Move distro tarball to the Maven install phase.
## Documentation
SAFE_CAST to be documented and relevant syntax additions to be documented.
## Testing
Failing tests now pass.
> Accommodate RexBuilder changes made for SAFE_CAST
> -------------------------------------------------
>
> Key: DRILL-8424
> URL: https://issues.apache.org/jira/browse/DRILL-8424
> Project: Apache Drill
> Issue Type: Improvement
> Components: Query Planning & Optimization
> Affects Versions: 1.22.0
> Reporter: James Turton
> Assignee: James Turton
> Priority: Major
> Fix For: 1.22.0
>
>
> The introduction of SAFE_CAST support in CALCITE-5575 made method signature
> changes in RexBuilder that broke a needed override in DrillRexBuilder.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
