[jira] [Commented] (DRILL-8424) Accommodate RexBuilder changes made for SAFE_CAST

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/DRILL-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713133#comment-17713133
 ] 

ASF GitHub Bot commented on DRILL-8424:
---------------------------------------

jnturton commented on code in PR #2794:
URL: https://github.com/apache/drill/pull/2794#discussion_r1168859598


##########
exec/java-exec/src/main/codegen/templates/Parser.jj:
##########
@@ -7727,6 +7764,8 @@ SqlPostfixOperator PostfixRowOperator() :
 |   < DATETIME_INTERVAL_CODE: "DATETIME_INTERVAL_CODE" >
 |   < DATETIME_INTERVAL_PRECISION: "DATETIME_INTERVAL_PRECISION" >
 |   < DAY: "DAY" >
+|   < DAYOFWEEK: "DAYOFWEEK" >
+|   < DAYOFYEAR: "DAYOFYEAR" >

Review Comment:
   Yes we should, thanks, added.





> Accommodate RexBuilder changes made for SAFE_CAST
> -------------------------------------------------
>
>                 Key: DRILL-8424
>                 URL: https://issues.apache.org/jira/browse/DRILL-8424
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Query Planning &amp; Optimization
>    Affects Versions: 1.22.0
>            Reporter: James Turton
>            Assignee: James Turton
>            Priority: Major
>             Fix For: 1.22.0
>
>
> The introduction of SAFE_CAST support in CALCITE-5575 made method signature 
> changes in RexBuilder that broke a needed override in DrillRexBuilder.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)