[ https://issues.apache.org/jira/browse/DRILL-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803477#comment-17803477 ]
ASF GitHub Bot commented on DRILL-8465: --------------------------------------- jnturton commented on PR #2853: URL: https://github.com/apache/drill/pull/2853#issuecomment-1878400693 I've started looking at this. First question: if we're adding dynamically loaded class checks to protect against untrusted code then is checking the package name worth much? Or do we need to do something like verify signatures against a list of trusted keys? Second question: if this is about security then is the code we're loading actually untrusted or is it only ever loaded from serialisations that we produced ourselves (e.g. in IcebergWorkSerializer)? P.S. Please include this "Why we're doing this" background that I'm lacking in the Jira issue when it's nontrivial. > Check data input when loading iceberg data > ------------------------------------------ > > Key: DRILL-8465 > URL: https://issues.apache.org/jira/browse/DRILL-8465 > Project: Apache Drill > Issue Type: Improvement > Components: Storage - Iceberg > Reporter: PJ Fanning > Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)