[
https://issues.apache.org/jira/browse/DRILL-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18091650#comment-18091650
]
ASF GitHub Bot commented on DRILL-8543:
---------------------------------------
rymarm commented on PR #3036:
URL: https://github.com/apache/drill/pull/3036#issuecomment-4801154269
@cgivre Thank you for the changes! Everything looks good. The only thing I
wrote about that didn't seem to be understood correctly. Why do you use the
full class name:
```java
org.apache.calcite.sql.SqlNode parsedNode =
sqlConverter.parse(scanSql.toString());
org.apache.calcite.sql.SqlNode validatedNode =
sqlConverter.validate(parsedNode);
```
instead of import:
```java
import org.apache.calcite.sql.SqlNode;
```
Here:
https://github.com/cgivre/drill/blob/cf26170180103a55ab4ec7ba3fc2c01a0bc6855e/exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/MaterializedViewRewriter.java#L171-L171
https://github.com/cgivre/drill/blob/cf26170180103a55ab4ec7ba3fc2c01a0bc6855e/exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/MaterializedViewRewriter.java#L207-L208
> Add Support for Materialized Views
> ----------------------------------
>
> Key: DRILL-8543
> URL: https://issues.apache.org/jira/browse/DRILL-8543
> Project: Apache Drill
> Issue Type: New Feature
> Components: Metadata, Query Planning & Optimization
> Affects Versions: 1.22.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.23.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
