[ 
https://issues.apache.org/jira/browse/FINERACT-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595961#comment-16595961
 ] 

ASF GitHub Bot commented on FINERACT-623:
-----------------------------------------

ShruthiRajaram commented on issue #454: FINERACT-623 - Restriction of product 
mix fix
URL: https://github.com/apache/fineract/pull/454#issuecomment-416833518
 
 
   @MexinaD  I think there is a little confusion over my last comment. I was 
completely fine with validation during disbursal and submission. All I wanted 
to convey was, change the method signature of "checkForProductMixRestrictions" 
and "checkForProductMixRestrictions" present in 
LoanWritePlatformServiceJpaRepositoryImpl, so that you can have a common method 
and call it from  "LoanApplicationWritePlatformServiceJpaRepositoryImpl" and 
"LoanWritePlatformServiceJpaRepositoryImpl". So that you handle all the 
scenarios you described previously. I believe the current change checks only 
during submission. If you want to check only during the submission and not 
during disbursal for existing loans, let me know I will approve the change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The restriction of product mix should apply during submission of another loan
> -----------------------------------------------------------------------------
>
>                 Key: FINERACT-623
>                 URL: https://issues.apache.org/jira/browse/FINERACT-623
>             Project: Apache Fineract
>          Issue Type: Bug
>            Reporter: Mexina Daniel
>            Priority: Major
>              Labels: gsoc, p2
>
> For now when you configure one loan account of Product1 not to be applied 
> when a client already have another loan account of Product2, during the 
> application of another loan account, the system accept to submit and approve 
> the loan and give the error of co-exist during disburse.
> Expected: The system should give the error of co-exist of the restricted loan 
> when a user is submitting the new loan account since the two loans should not 
> exist together.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to