[
https://issues.apache.org/jira/browse/FINERACT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013819#comment-17013819
]
Michael Vorburger commented on FINERACT-821:
--------------------------------------------
I guess the only way to realistically really make progress on something like
this for a large existing codebase like Fineract is to do this gradually... I
propose that we make a start with first cleaning up all whitespace issues, so
for all Java files: 1. convert all Java files from DOS to UNIX line ending, 2.
replace Tabs with 4 Spaces, 3. remove all trailing spaces; [pull/688
|https://github.com/apache/fineract/pull/688] does that.
We can then enforce that via Checkstyle. The initial Checkstyle XML
configuration file I'll contribute will have many rules, but most of them still
commented out, and only the whitespace related ones activated. The idea would
be that we (myself or, hopefully, other contributors!) over time then gradually
enable more of those rules, after fixing existing violations:
[pull/689|https://github.com/apache/fineract/pull/689]
> Enable and enforce (!) Checkstyle in Fineract
> ---------------------------------------------
>
> Key: FINERACT-821
> URL: https://issues.apache.org/jira/browse/FINERACT-821
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Michael Vorburger
> Assignee: Michael Vorburger
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> as suggested in FINERACT-712, we really should enable Checkstyle in Fineract.
> My past experience in such matters, confirmed by FINERACT-702, is that these
> things only ever work and have a lasting effect if you bulk fix all
> violations and switch on enforcement. If you only report, it's mostly useless.
> As for specific Checkstyle rules, I have spent a fair amount of time in a
> past life on a project (which I'm currently no longer actively invoved in) to
> refine a what I believe to be "good" Checkstyle rule set, we could reuse this
> for Fineract (it's EPL licensed, so copy/pasting it is perfectly fine), see
> https://github.com/opendaylight/odlparent/blob/master/checkstyle/src/main/resources/odl_checks.xml
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
