[ https://issues.apache.org/jira/browse/FINERACT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081680#comment-17081680 ]
Awasum Yannick commented on FINERACT-821: ----------------------------------------- [~xurror], Are you still working on this? If not, you may want to liberate it lets know which issues are still available. I see you are focused on completely your PRs so they can be merged and may not have time for this. > Enable and enforce (!) Checkstyle in Fineract > --------------------------------------------- > > Key: FINERACT-821 > URL: https://issues.apache.org/jira/browse/FINERACT-821 > Project: Apache Fineract > Issue Type: Improvement > Reporter: Michael Vorburger > Assignee: Yemdjih Kaze Nasser > Priority: Major > Fix For: 1.4.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > as suggested in FINERACT-712, we really should enable Checkstyle in Fineract. > My past experience in such matters, confirmed by FINERACT-702, is that these > things only ever work and have a lasting effect if you bulk fix all > violations and switch on enforcement. If you only report, it's mostly useless. > As for specific Checkstyle rules, I have spent a fair amount of time in a > past life on a project (which I'm currently no longer actively invoved in) to > refine a what I believe to be "good" Checkstyle rule set, we could reuse this > for Fineract (it's EPL licensed, so copy/pasting it is perfectly fine), see > https://github.com/opendaylight/odlparent/blob/master/checkstyle/src/main/resources/odl_checks.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)