[
https://issues.apache.org/jira/browse/FINERACT-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Vorburger updated FINERACT-1207:
----------------------------------------
Description:
[~aleks] while code reviewing your
[https://github.com/apache/fineract/pull/1402/] for FINERACT-1189, I've noticed
that
[fineract-provider/config/swagger/|https://github.com/apache/fineract/tree/1d0d7c1bd8d20b10fa67743ceaa7372ce603278e/fineract-provider/config/swagger/]
still exists today (in that PR, and soon in develop, as I'm hoping to merge
ASAP).
Was that intentional, or an oversight? That doesn't seem right, now, agreed?
Do you want to raise a PR to just remove it? Or does what's there have to be
moved into the (new) {{fineract-client}} now?
Or perhaps [~Grandolf49] you would like to do that?
[~ptuomola] FYI
was:
[~aleks] while code reviewing your
[https://github.com/apache/fineract/pull/1402/] for FINERACT-1189, I've noticed
that
[fineract-provider/config/swagger/templates|https://github.com/apache/fineract/tree/1d0d7c1bd8d20b10fa67743ceaa7372ce603278e/fineract-provider/config/swagger/templates]
still exists today (in that PR, and soon in develop, as I'm hoping to merge
ASAP).
Was that intentional, or an oversight? That doesn't seem right, now, agreed?
Do you want to raise a PR to just remove it? Or does what's there have to be
moved into the (new) {{fineract-client}} now?
Or perhaps [~Grandolf49] you would like to do that?
[~ptuomola] FYI
> Clean up fineract-provider/config/swagger following introduction of
> fineract-client/
> ------------------------------------------------------------------------------------
>
> Key: FINERACT-1207
> URL: https://issues.apache.org/jira/browse/FINERACT-1207
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Michael Vorburger
> Assignee: Aleksandar Vidakovic
> Priority: Minor
> Fix For: 1.5.0
>
>
> [~aleks] while code reviewing your
> [https://github.com/apache/fineract/pull/1402/] for FINERACT-1189, I've
> noticed that
> [fineract-provider/config/swagger/|https://github.com/apache/fineract/tree/1d0d7c1bd8d20b10fa67743ceaa7372ce603278e/fineract-provider/config/swagger/]
> still exists today (in that PR, and soon in develop, as I'm hoping to merge
> ASAP).
> Was that intentional, or an oversight? That doesn't seem right, now, agreed?
> Do you want to raise a PR to just remove it? Or does what's there have to be
> moved into the (new) {{fineract-client}} now?
> Or perhaps [~Grandolf49] you would like to do that?
> [~ptuomola] FYI
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
