San-43 commented on PR #5801: URL: https://github.com/apache/fineract/pull/5801#issuecomment-4312507085
integration test failures were caused by three regressions introduced by these changes: - `postInterestAsOn` validation became backward-incompatible because existing tests/helpers still sent the legacy `postInterestManualOrAutomatic` flag, while the new validation only accepted `isPostInterestAsOn`. - `releaseAmount` validation became backward-incompatible because existing callers still sent legacy payloads, including generic transaction fields and `isBulk` in batch flows. - Several interest-posting integration tests were not null-safe after `externalId` was added to transaction responses, because they called `toString()` on nullable map values. There were also two `ClientSavingsIntegrationTest` cases that started returning `403` once the legacy manual-interest flag was interpreted correctly. In that case the backend behavior was valid: the tests were posting manual interest with a date earlier than already-posted transactions, which is rejected by the existing business rule. PS: e2e test failures are unrelated `Java heap space` I believe I fixed these regressions and the affected tests in my last commit. @adamsaghy please take a look when u have a time, i may need some guidance here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
