Aman-Mittal commented on PR #5801: URL: https://github.com/apache/fineract/pull/5801#issuecomment-4317928267
> @San-43 LGTM @Aman-Mittal still 1 commit per PR applies? While FSIP-7 proposal intention was to preserve sign commits for merge instead of "Squash and Commit" it should be merged normally. While it is also mentioned. Encourage developers to use as few or as many commits as they choose in their PRs, with the intent to most clearly communicate the reviewable progress of their work during PR review and for posterity. This means rebasing locally, adding/removing commits, and force-pushing are all still allowed, although these should be used only as necessary/helpful (e.g. when a new commit on develop assists the PR or to correct noise/mistakes). If force-push is used, communicate it thoughtfully. Its up to you (reviewer) if you want him rebase or not is multiple commits justify for the work he has done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
