Aman-Mittal commented on code in PR #5763:
URL: https://github.com/apache/fineract/pull/5763#discussion_r3152676888
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/SavingsAccountTransactionTest.java:
##########
@@ -444,8 +452,8 @@ private void runDeadlockBatch(SavingsAccountHelper
savingsHelper, Integer saving
String msg = Strings.nullToEmpty(response1.getBody());
assertNotNull(statusCode, "First response status code");
assertTrue(
- SC_OK == statusCode || SC_CONFLICT == statusCode
- || (SC_FORBIDDEN == statusCode && msg.contains("Cannot
add or update a child row")),
+ SC_OK == statusCode || SC_CONFLICT == statusCode ||
(SC_FORBIDDEN == statusCode
+ && (msg.contains("Cannot add or update a child row")
|| msg.contains("Record has changed since last read"))),
Review Comment:
You should maintain constants instead of duplicated string literals
"Record has changed since last read"
This is not maintainable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
