adamsaghy commented on code in PR #5763:
URL: https://github.com/apache/fineract/pull/5763#discussion_r3274817696
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/exception/ErrorHandler.java:
##########
@@ -72,8 +72,7 @@ private enum PessimisticLockingFailureCode {
ROLLBACK("40"), // Transaction rollback
DEADLOCK("60"), // Oracle: deadlock
- HY00("HY", "Lock wait timeout exceeded"), // MySql deadlock HY00
- ;
+ HY00("HY", "Lock wait timeout exceeded"), SNAPSHOT_CONFLICT("HY",
"Record has changed since last read");
Review Comment:
I dont think it is valid to use the very same code for two different errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]