Aman-Mittal commented on code in PR #5813:
URL: https://github.com/apache/fineract/pull/5813#discussion_r3167410122


##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java:
##########
@@ -173,7 +173,9 @@ public CollectionData calculateLoanCollectionData(final 
Long loanId) {
             // loans
             collectionData = 
loanDelinquencyDomainService.getOverdueCollectionData(loan, 
effectiveDelinquencyList);
             
collectionData.setAvailableDisbursementAmount(calculateAvailableDisbursementAmount(loan));
-            
collectionData.setAvailableDisbursementAmountWithOverApplied(calculateAvailableDisbursementAmountWithOverApplied(loan));
+            if (loan.getLoanProduct() != null) {
+                
collectionData.setAvailableDisbursementAmountWithOverApplied(calculateAvailableDisbursementAmountWithOverApplied(loan));

Review Comment:
   Can you please explain when loanProduct is required in 
calculateAvailableDisbursementAmountWithOverApplied function ?  When 
loanProduct is not present what part of loan product it utilize when 
calculating AvailableDisburementAmountWithOverApplied



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to