adamsaghy commented on code in PR #5771:
URL: https://github.com/apache/fineract/pull/5771#discussion_r3170419512


##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/calc/ProjectedAmortizationScheduleModel.java:
##########
@@ -79,6 +82,9 @@ public final class ProjectedAmortizationScheduleModel {
     @Getter(AccessLevel.NONE)
     private final List<AppliedPayment> appliedPayments;
 
+    @Getter(AccessLevel.NONE)
+    private final List<RateSegment> rateSegments;

Review Comment:
   I was wondering whether we should rename this to reflect better the involved 
logic:
   - We are changing the projected payment **amount**
   
   I dont think the model need to know the payment percentage rate, but rather 
what is the expected payment amount only, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to