galovics commented on code in PR #5771:
URL: https://github.com/apache/fineract/pull/5771#discussion_r3221536576
##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanWritePlatformServiceImpl.java:
##########
@@ -668,6 +671,57 @@ public CommandProcessingResult creditBalanceRefund(final
Long loanId, final Json
.withClientId(loan.getClientId()).withLoanId(loanId).with(changes).build();
}
+ @Override
+ @Transactional
+ public CommandProcessingResult updatePeriodPaymentRate(final Long loanId,
final JsonCommand command) {
+ final WorkingCapitalLoan loan = this.loanRepository.findById(loanId)
+ .orElseThrow(() -> new
WorkingCapitalLoanNotFoundException(loanId));
+ this.validator.validateUpdatePeriodPaymentRate(command.json(), loan);
+
+ final BigDecimal newRate =
this.fromApiJsonHelper.extractBigDecimalNamed(WorkingCapitalLoanConstants.periodPaymentRateParamName,
+ command.parsedJson(), new HashSet<>());
+ final BigDecimal previousRate =
loan.getLoanProductRelatedDetails().getPeriodPaymentRate();
+
+ final LocalDate businessDate = DateUtils.getBusinessLocalDate();
+
+ final List<WorkingCapitalLoanPeriodPaymentRateChange> activeChanges =
this.rateChangeRepository
+ .findByWorkingCapitalLoanIdAndReversedFalse(loanId);
+ for (final WorkingCapitalLoanPeriodPaymentRateChange active :
activeChanges) {
+ active.reverse(businessDate);
+ }
+ if (!activeChanges.isEmpty()) {
+ this.rateChangeRepository.saveAll(activeChanges);
Review Comment:
Why call `saveAll`? The entities you fetched are managed within the
`@Transactional` method. Same for `loanRepository.saveAndFlush(loan)` further
below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
