rhopman commented on PR #5827: URL: https://github.com/apache/fineract/pull/5827#issuecomment-4438189649
Hi @Aman-Mittal, thank you for your thorough review. My intention is to limit this change to the scenario where a group savings account (no `clientId`) is used as guarantor for a loan. I would only consider this a self-guarantee if the loan itself is a group loan (no `clientId`) from the same group (same `groupId`). So the group itself (as a separate entity) is taking out a loan and partially or fully self-guaranteeing, using a savings account that belongs to the same group, but not to any individual group member or other client). I think there are different ways to look a this, but the above makes the most sense to me, and matches my business requirements. I have added some documentation and fixed the suppressed / deprecated issues. This makes the change bigger than strictly necessary but hopefully it is a step in the right direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
