vidakovic commented on code in PR #5811:
URL: https://github.com/apache/fineract/pull/5811#discussion_r3310150555
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/api/AccountTransfersApiResource.java:
##########
@@ -70,7 +75,6 @@ public class AccountTransfersApiResource {
+
"accounttransfers/template?fromClientId=1&fromAccountType=2&fromAccountId=1")
@ApiResponse(responseCode = "200", description = "OK", content =
@Content(schema = @Schema(implementation =
AccountTransfersApiResourceSwagger.GetAccountTransfersTemplateResponse.class)))
Review Comment:
When we are already type-safe then we don't need these `@ApiResponse` and
especially not `@Schema` annotations. Response code 200 is anyway trivial,
because that's the default anyway. In short: the goal is to get rid of
`AccountTransfersApiResourceSwagger` (and similar "Swagger" suffixed) classes
in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
