oleksii-novikov-onix commented on code in PR #5865:
URL: https://github.com/apache/fineract/pull/5865#discussion_r3322900710
##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/helper/ErrorMessageHelper.java:
##########
@@ -1102,34 +1102,10 @@ public static String
undoDisbursalDisallowedFailure(String status) {
return String.format("Transition LOAN_DISBURSAL_UNDO is not allowed
from status %s", status);
}
- public static String discountAmountExceedFailure() {
Review Comment:
We currently have two approaches for e2e validation checks that are used
simultaneously in the framework:
1. Create a separate step and corresponding ErrorMessageHelper method for
each validation error.
2. Use a single step where the error code is parameterized.
For discount externalId validation I decided to use the second approach,
which I believe is the better one. At the same time, I decided to completely
remove ambiguity, duplication, and dead code from
WorkingCapitalDiscount.feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
