elnafateh commented on PR #5946: URL: https://github.com/apache/fineract/pull/5946#issuecomment-4651343691
@adamsaghy You're right it looks half done but here's why. the first commit for this PR carries a full migration of these modules - ExternalEventConfigurationHelper - ExternalEventHelper - StandingInstructionsHelper - ProvisioningHelper - ProvisioningTransactionHelper when pushed the migrations then CI failed some DB checks, Indicating some mismatch in the OpenAPI spec from Provisioning* modules (PostProvisioningCriteriaRequest` generated model serializes the definitions list as `provisioningcriteria` via Jackson, but the server API expects `definitions ). Am left w two choice, either drop the Provisioning* modules from the migration or create some workaround/patch, I then choose the former and obviously the revert was not complete -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
