adamsaghy commented on code in PR #5946:
URL: https://github.com/apache/fineract/pull/5946#discussion_r3421171956
##########
fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/api/ProvisioningCriteriaApiResourceSwagger.java:
##########
@@ -42,7 +42,7 @@ private PostProvisioningCriteriaRequest() {
@Schema(example = "High Risk Products Criteria")
public String criteriaName;
public Collection<LoanProductData> loanProducts;
- public Collection<ProvisioningCriteriaDefinitionData>
provisioningcriteria;
+ public Collection<ProvisioningCriteriaDefinitionData> definitions;
Review Comment:
why to rename?
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/api/StandingInstructionApiResourceSwagger.java:
##########
@@ -63,7 +63,7 @@ private
GetFromAccountTypeResponseStandingInstructionSwagger() {}
@Schema(example = "accountType.savings")
public String code;
@Schema(example = "Savings Account")
- public String description;
+ public String value;
Review Comment:
why to rename?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
