alberto-art3ch commented on PR #5883: URL: https://github.com/apache/fineract/pull/5883#issuecomment-4651765255
> All four review comments from my previous pass have been addressed: > > * Spring @transactional is used instead of Jakarta > * provider is modeled as OidcFederationType enum > * catch block in OidcTenantAwareFilter now logs a warning > * The hardcoded 1L for head office is replaced with a configurable fineractProperties.getDefaults().getOfficeId() > > The mailing list requirement (per-tenant OIDC configuration, different IdP per tenant) has also been implemented - the m_tenant_oidc_config table, TenantOidcConfigApiResource, and DynamicJwtIssuerAuthenticationManagerResolver address exactly what I asked for on the thread. > > Build quality checks still need to be green before merge. @galovics Quality checks are now in green. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
