Dhanno98 commented on code in PR #5940:
URL: https://github.com/apache/fineract/pull/5940#discussion_r3454281685
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientChargeWritePlatformServiceImpl.java:
##########
@@ -95,7 +99,12 @@ public CommandProcessingResult addCharge(Long clientId,
JsonCommand command) {
throw new ChargeCannotBeAppliedToException("client",
errorMessage, charge.getId());
}
- final ClientCharge clientCharge = ClientCharge.createNew(client,
charge, command);
+ BigDecimal roundedAmount = calculateRoundedChargeAmount(charge,
command);
+ if (roundedAmount.compareTo(BigDecimal.ZERO) == 0) {
+ return new
CommandProcessingResultBuilder().withOfficeId(client.getOffice().getId()).withClientId(client.getId()).build();
Review Comment:
Yes, it is incorrect, and I have made the change to throw now a
`PlatformApiDataValidationException` when the final charge amount rounds to 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
