nidhiii128 opened a new pull request, #6049: URL: https://github.com/apache/fineract/pull/6049
JIRA: https://issues.apache.org/jira/browse/FINERACT-2293 Migrates the create client address endpoint (POST /v1/client/{clientId}/addresses?type={addressTypeId}) from the legacy JsonCommand command-processing path to the new typed fineract-command framework. Scope (PR 1 of 2 for FINERACT-2293) - New typed AddressCreateRequest / AddressCreateResponse POJOs with Jakarta Validation - New AddressMapper (MapStruct) — no JsonObject in the new code path - New AddressDomainService / AddressDomainServiceImpl — typed write service following the template module (FINERACT-2564) pattern - New AddressCreateCommand / AddressCreateCommandHandler using CommandHandler<REQ, RES> - Controller routes through CommandDispatcher and returns AddressCreateResponse directly - AntMatcher added in SecurityConfig for POST /api/*/client/*/addresses (CREATE_ADDRESS) - Resilience4j retry config for commandAddressCreate - Validation message bundle entries added - Legacy AddClientAddressCommandHandler deleted - Legacy addClientAddress(Long, Long, JsonCommand) method removed from AddressWritePlatformService (no remaining callers) - Legacy CommandWrapperBuilder.addClientAddress(Long, Long) builder method removed addNewClientAddress(Client, JsonCommand) kept on AddressWritePlatformService since it is still called by the client creation flow (ClientWritePlatformServiceJpaRepositoryImpl). That migration is out of scope here. Pattern follows the merged template-module reference (apache/fineract#5851). ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
