DhroovSankla commented on code in PR #6090: URL: https://github.com/apache/fineract/pull/6090#discussion_r3524871813
########## fineract-mix/src/main/java/org/apache/fineract/mix/data/MixReportXBRLDocument.java: ########## @@ -0,0 +1,127 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.mix.data; + +import jakarta.xml.bind.annotation.XmlAnyElement; +import jakarta.xml.bind.annotation.XmlElement; +import jakarta.xml.bind.annotation.XmlRootElement; +import java.io.Serial; +import java.io.Serializable; +import java.util.ArrayList; +import java.util.List; +import lombok.Data; +import lombok.NoArgsConstructor; +import org.w3c.dom.Element; + +@Data +@NoArgsConstructor +@XmlRootElement(name = "xbrl") +public class MixReportXBRLDocument implements Serializable { + + @Serial + private static final long serialVersionUID = 1L; + + private List<Element> taxonomyElements = new ArrayList<>(); + private List<XBRLContextDTO> contexts = new ArrayList<>(); + private List<XBRLUnitDTO> units = new ArrayList<>(); + + @XmlElement(name = "schemaRef") + public SchemaRefDTO getSchemaRef() { + return new SchemaRefDTO(); + } + + @XmlAnyElement + public List<Element> getTaxonomyElements() { + return this.taxonomyElements; + } + + @XmlElement(name = "context") + public List<XBRLContextDTO> getContexts() { + return this.contexts; + } + + @XmlElement(name = "unit") + public List<XBRLUnitDTO> getUnits() { + return this.units; + } + + @lombok.Getter + @lombok.Setter + public static class SchemaRefDTO { + + private final String link = "http://www.themix.org/sites/default/files/Taxonomy2010/dct/dc-all_2010-08-31.xsd";; Review Comment: Hi @Aman-Mittal, Thank you for your review and for keeping a close eye on legal compliance! I want to clarify that this PR does **not** introduce any new third-party library or external software dependency here. The `String link` value you highlighted is simply a static metadata URI string literal required verbatim by the XBRL standard schema specification layout. It is used purely as an identifier text for the XML document graph structure; no connection or runtime dependency tracking is made to `themix.org`. This exact URI token was pulled directly from the legacy manual string generation logic we are refactoring. The only actual build artifact dependency introduced in this modernization is `jakarta.xml.bind-api` in `build.gradle`, which is fully compliant under the standard Eclipse Foundation / Apache-approved open-source licensing guidelines. Please let me know if this clears up the concern or if you would like me to rename the variable wrapper to something like `NAMESPACE_URI` to prevent any visual confusion! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
