NkwaTambe opened a new pull request, #6095: URL: https://github.com/apache/fineract/pull/6095
## Summary The `ApiKeyFilter` hardcoded the header name `X-KYC-Api-Key`, inherited from the deprecated `webank-kyc-manager`. The SMS gateway is not a KYC manager — it only handles OTP delivery and SMS sending. Rename the header to `X-SMS-Gateway-Api-Key` to match the service's actual purpose. ## Changes - `ApiKeyFilter.java`: `API_KEY_HEADER` constant renamed from `X-KYC-Api-Key` to `X-SMS-Gateway-Api-Key` ## Coordinated cross-repo changes This is a coordinated change with the BFF (**webank-mobile**) which sends the same header name via its `smsgateway` client (renamed from `kycmanager`). The BFF PR must be merged together with this one to avoid auth failures. - **webank-mobile** PR: <TBD> - **webank-verify** README fix: <TBD> ## Verification - No tests reference the old header name (confirmed via grep) - The header value (`SMS_GATEWAY_API_KEY` env var) is unchanged ## AI Usage Declaration - **AI used for**: Code audit, header rename - **Verified**: grep confirms no remaining `X-KYC-Api-Key` references in the sms-gateway module -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
