Dhanno98 commented on PR #5940: URL: https://github.com/apache/fineract/pull/5940#issuecomment-4895936836
I went through the remaining failing CI job (`run-api-backward-compatibility`) to understand the failure. From what I observed, the reported breaking changes are due to the generated client schema updates that I made for: * `PostAccountsTypeAccountIdRequest` (to expose the missing request fields required for share account activation/redemption), and * `PostClientsClientIdChargesRequest` (correcting `amount` to `BigDecimal`). I also noticed that the additional fields added to `PostProductsTypeRequest` for accounting-enabled share product creation are additive and don't seem to be reported by the backward compatibility check. It looks like the failure is specifically because the OpenAPI contract changed for the existing request models. Could you please let me know how you would like me to proceed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
