Dhanno98 commented on code in PR #5940:
URL: https://github.com/apache/fineract/pull/5940#discussion_r3551783738
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/accounts/api/AccountsApiResourceSwagger.java:
##########
@@ -465,15 +465,26 @@ public static final class
PostAccountsTypeAccountIdRequest {
private PostAccountsTypeAccountIdRequest() {}
+ @Schema(example = "en")
+ public String locale;
+ @Schema(example = "dd MMMM yyyy")
+ public String dateFormat;
+ @Schema(example = "01 January 2026")
+ public String activatedDate;
+ @Schema(example = "05 May 2026")
+ public String requestedDate;
+ @Schema(example = "01 January 2026")
+ public String closedDate;
+ @Schema(example = "100", description = "Number of shares to redeem or
a collection of transaction IDs depending on the command.")
+ public Object requestedShares;
Review Comment:
Thanks for the suggestion! Just to clarify, would you like me to revert only
the `PostAccountsTypeAccountIdRequest` Swagger changes where there is ambiguity
regarding using `Object` for `requestedShares`, or would you prefer all of the
Swagger schema updates in this PR to be reverted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
