DeathGun44 commented on code in PR #6084:
URL: https://github.com/apache/fineract/pull/6084#discussion_r3535503110


##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/loan/reamortization/LoanReAmortizationIntegrationTest.java:
##########
@@ -1120,20 +1115,15 @@ private Long 
createLoanProductWithMultiDisbursalAndRepaymentsWithEnableDownPayme
         product.setEnableAutoRepaymentForDownPayment(true);
         product.setInstallmentAmountInMultiplesOf(null);
 
-        PostLoanProductsResponse loanProductResponse = 
loanProductHelper.createLoanProduct(product);
-        GetLoanProductsProductIdResponse getLoanProductsProductIdResponse = 
loanProductHelper
-                .retrieveLoanProductById(loanProductResponse.getResourceId());
-        assertNotNull(getLoanProductsProductIdResponse);
-        return loanProductResponse.getResourceId();
+        Long loanProductId = createLoanProduct(product);
+        GetLoanProductsProductIdResponse retrievedProduct = 
retrieveLoanProduct(loanProductId);
+        assertNotNull(retrievedProduct);
+        return loanProductId;
     }
 
     private Long addChargeWithCurrency(Long loanId, boolean isPenalty, double 
amount, String dueDate, String currencyCode) {

Review Comment:
   Fixed! it now branches to loanSpecifiedDueDatePenalty(...) when isPenalty is 
true, ...Fee(...) otherwise.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to