adamsaghy commented on code in PR #6084:
URL: https://github.com/apache/fineract/pull/6084#discussion_r3542880603
##########
fineract-provider/src/test/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTest.java:
##########
@@ -203,7 +205,7 @@ public void testGetLastUserTransaction() {
@Test
public void testTransactionComparator() {
final Loan loan = new Loan();
- LocalDate today = LocalDate.of(2023, 10, 12);
+ LocalDate today = LocalDate.of(2023, Month.OCTOBER, 12);
Review Comment:
this does not really help readability...
##########
fineract-provider/src/test/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTest.java:
##########
@@ -273,7 +275,7 @@ private LoanCharge buildLoanCharge() {
loanCharge.setAmountOutstanding(new BigDecimal(100));
loanCharge.setChargeTime(ChargeTimeType.TRANCHE_DISBURSEMENT.getValue());
loanCharge.setChargeCalculation(ChargeCalculationType.FLAT.getValue());
- loanCharge.setDueDate(LocalDate.of(2022, 6, 27));
+ loanCharge.setDueDate(LocalDate.of(2022, Month.JUNE, 27));
Review Comment:
this does not really help readability...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
