aya-abdallah-FOO commented on PR #6209: URL: https://github.com/apache/fineract/pull/6209#issuecomment-5165721363
> > > > > squash the two commits into one > > > > > > > > > > > > @elnafateh it would be better to keep the 2 commits seperated by the 2 tickets as they are related to each other and the second depends on the fixes in the first > > > > > > > > > Yeah Maybe but It does'nt matter, It's a fineract rule... > > > > > > @elnafateh what is the rule? > > Since the PR says: `FINERACT-2727: Fix loan product visibility when office-specific-products-enabled is on`, it should contains only these changes. > > @elnafateh is asking you to create a new PR for the`FINERACT-2728: Apply office-based charge filtering aligned with loan product visibility` commit. @adamsaghy the issue here is that for the commit 2 if i want to create the new PR it needs commit 1 to be merged first or i need to base from the PR branch instead of develop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
