AshharAhmadKhan opened a new pull request, #6234:
URL: https://github.com/apache/fineract/pull/6234

   ## JIRA
   https://issues.apache.org/jira/browse/FINERACT-2741
   
   ## Problem
   Email address columns across Fineract tables (`m_client`, `m_staff`, 
`m_appuser`, etc.) are currently capped at 50–150 characters, falling short of 
the RFC 5321 maximum of 254 characters. This risks truncating or rejecting 
valid, longer email addresses.
   
   ## Fix
   Widened the following columns to `VARCHAR(254)`:
   
   | Table | Column | Before | After |
   |---|---|---|---|
   | `m_appuser` | `email` | VARCHAR(100) | VARCHAR(254) |
   | `m_client` | `email_address` | VARCHAR(150) | VARCHAR(254) |
   | `m_staff` | `email_address` | VARCHAR(150) | VARCHAR(254) |
   | `scheduled_email_messages_outbound` | `email_address` | VARCHAR(50) | 
VARCHAR(254) |
   
   Added a new Liquibase changeset 
(`0245_standardize_email_address_column_length.xml`, registered in 
`changelog-tenant.xml`) rather than editing `0001_initial_schema.xml`, since 
that file is already-released history.
   
   Updated the following to stay in lockstep with the new column widths:
   - JPA `@Column(length=...)` on `AppUser`, `Client`, `Staff`, `EmailMessage`
   - `UserDataValidator.notExceedingLengthOf(...)` (create + update paths)
   - `@Length(max=...)` on `StaffCreateRequest` and `StaffUpdateRequest`
   
   **Out of scope:**
   - `m_adhoc.email` (already `VARCHAR(500)`) — exceeds the new standard 
already; ticket specifies no column sizes are reduced, so left as-is.
   - `request_audit_table.email` (`VARCHAR(100)`) — no backing JPA entity or 
code reference found anywhere in the repo. Appears to be dead/legacy schema. 
Flagging here for reviewer input on whether to widen for consistency or leave 
untouched.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to