AshharAhmadKhan commented on code in PR #6234: URL: https://github.com/apache/fineract/pull/6234#discussion_r3750451910
########## fineract-provider/src/main/resources/db/changelog/tenant/parts/0245_standardize_email_address_column_length.xml: ########## @@ -0,0 +1,32 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.3.xsd";> + <!-- FINERACT-2741: Standardize email address column length to VARCHAR(254) (RFC 5321 max) --> + <changeSet author="fineract" id="1"> + <modifyDataType tableName="m_appuser" columnName="email" newDataType="VARCHAR(254)"/> + <modifyDataType tableName="m_client" columnName="email_address" newDataType="VARCHAR(254)"/> + <modifyDataType tableName="m_staff" columnName="email_address" newDataType="VARCHAR(254)"/> + <modifyDataType tableName="scheduled_email_messages_outbound" columnName="email_address" newDataType="VARCHAR(254)"/> Review Comment: Hey Adam, thanks for pointing this out. As mentioned in the description, I couldn’t find any backing entity or code reference for `request_audit_table`, so I assumed it was unnecessary legacy schema and left it unchanged. What exactly is `request_audit_table` used for, by the way? If it’s still useful, I can add the email column change for consistency. If not, I can leave it for a separate cleanup ticket to remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
