Aman-Mittal opened a new issue, #291: URL: https://github.com/apache/fineract-backoffice-ui/issues/291
Part of #288. Depends on #289 — wait for it to merge. ## Business value `savings-product-form.component.ts:263` and `:291` both hardcode `accountingRule: 1`. Until this lands, every deposit and withdrawal a branch takes is invisible to the ledger — customer deposits never appear as a liability, and interest paid to savers never reaches an expense account. For a deposit-taking institution the savings book is usually the largest single item on the balance sheet. It currently does not appear on it at all. ## What to build Using the components from #289, the savings mapping set: savings reference, savings control, interest on savings, income from fees, income from penalties, transfers in suspense, and overdraft portfolio plus write-off accounts where the product allows overdrafts. As with loans, **read the expected slots off the savings product template response** rather than trusting this list, and confirm against a live instance (`npm run e2e:stack`). ## One thing specific to savings Overdraft mappings are only relevant when the product permits an overdraft. The form already has an overdraft toggle — gate those fields on it, the same way the existing conditional sections work. Sending overdraft mappings on a product that does not allow overdrafts is the kind of thing the platform will either reject or silently keep, and neither is good. ## Testing - **Unit spec:** submitted body carries the savings mapping keys; overdraft mappings appear only when the overdraft toggle is on. - **Unit spec:** loading a configured product populates every mapping. - **Mocked e2e:** intercept the `POST` and assert the body — `Probe` pattern in `e2e/client-servicing-gaps.spec.ts`. - A **backend e2e** covering deposit → journal entry is welcome. #290 carries the equivalent check for loans; if that has landed, this one can be lighter. ## Scope In scope: savings product mappings, create and edit. Out of scope: fixed and recurring deposit products (#292 — they share a form family but have their own quirks), share products (#293), advanced mappings (#294). ## Getting started - `src/app/features/products/savings-product-form.component.ts` - Shared components from #289 - `npm test`, `npm run lint:prune`, `npm run i18n:check`, `npm run build` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
