Aman-Mittal commented on issue #355: URL: https://github.com/apache/fineract-backoffice-ui/issues/355#issuecomment-5303647864
Counts confirm on my side too: 21 files, 285 routes, `groups.routes.ts` the only one already done. No need to flag the 22 → 21 thing further. **Split:** five PRs, not 21 and not one. 1. `clients` (21 routes) — first, on its own, because it settles the naming convention. 2. `products` (65) 3. `system` (46) 4. `accounting` (25) + `loans` (24) 5. the remaining 16 files (~104 routes) as one PR The reason for landing clients alone first: the review cost here is not the diff, it is the key naming, and that decision is made once. Two things I want pinned down in that PR and written into this issue afterwards, so nobody has to re-derive them: - whether these reuse existing `nav.*` / `FEATURE.TITLE` keys or get new ones - what `view/:id` and `edit/:id` routes are titled. Angular's static `title` cannot interpolate the record, so these get a generic name. Say so explicitly, or 21 files will each invent something different. **What to leave:** take `products` and `system`. 111 near-identical title lines is drudgery, not a first contribution, and nobody new is going to enjoy it. Leave `accounting`, `loans`, `clients` and the 16 small files as newcomer work — with the convention already settled by your first PR, each of those is a genuinely good first issue rather than a guessing game. One thing not to do: `products.routes.ts` is 65 flat routes with no nesting, and it is tempting to restructure it into children so one parent title covers each entity's list/create/edit triple. Please don't fold that into this. It changes matching and guard behaviour, and it belongs in its own PR if it is worth doing at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
