Aman-Mittal commented on issue #355: URL: https://github.com/apache/fineract-backoffice-ui/issues/355#issuecomment-5312366326
@opensource-joe For > One thing I found and did not fix > Three list components in products carry hardcoded English headings rather than translation keys: fixed-deposits-list, recurring-deposits-list and share-accounts-list render title="Fixed Deposit Accounts" and similar. check-translations.mjs cannot catch this, because it only validates strings that are already keys. It is a real i18n bug but not a titling one, so those three routes take the correct nav.* keys and I have left the headings alone. Happy to file it separately if you want it tracked. > > Also, and much smaller: products/recurring and products/share are the product lists but render nav.recurringDeposits and nav.shares, which are the account labels. Their titles use nav.recurringDepositProducts and nav.shareProducts, so on those two the tab is right and the on-screen heading is wrong. You can create new issue for that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
