shubhamchaudhary29 commented on code in PR #6261:
URL: https://github.com/apache/fineract/pull/6261#discussion_r3796592763
##########
fineract-provider/src/main/java/org/apache/fineract/interoperation/service/InteropServiceImpl.java:
##########
@@ -406,8 +414,11 @@ public InteropTransferResponseData
prepareTransfer(@NonNull JsonCommand command)
savingsAccountRepository.save(savingsAccount);
}
- return InteropTransferResponseData.build(command.commandId(),
request.getTransactionCode(), InteropActionState.ACCEPTED,
- request.getExpiration(), request.getExtensionList(),
transferCode, DateUtils.getLocalDateTimeOfTenant());
+ LocalDateTime completedTimestamp =
DateUtils.getLocalDateTimeOfTenant();
+ InteropTransferResponseData response =
InteropTransferResponseData.build(command.commandId(),
request.getTransactionCode(),
+ InteropActionState.ACCEPTED, request.getExpiration(),
request.getExtensionList(), transferCode, completedTimestamp);
Review Comment:
Both use ACCEPTED because it means the request was successful. PREPARE and
CREATE are the actual transfer actions. This behavior already existed before my
changes. Should the query also show whether the transfer was prepared or
committed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
