adamsaghy commented on code in PR #6261:
URL: https://github.com/apache/fineract/pull/6261#discussion_r3796666159
##########
fineract-provider/src/main/java/org/apache/fineract/interoperation/service/InteropServiceImpl.java:
##########
@@ -406,8 +414,11 @@ public InteropTransferResponseData
prepareTransfer(@NonNull JsonCommand command)
savingsAccountRepository.save(savingsAccount);
}
- return InteropTransferResponseData.build(command.commandId(),
request.getTransactionCode(), InteropActionState.ACCEPTED,
- request.getExpiration(), request.getExtensionList(),
transferCode, DateUtils.getLocalDateTimeOfTenant());
+ LocalDateTime completedTimestamp =
DateUtils.getLocalDateTimeOfTenant();
+ InteropTransferResponseData response =
InteropTransferResponseData.build(command.commandId(),
request.getTransactionCode(),
+ InteropActionState.ACCEPTED, request.getExpiration(),
request.getExtensionList(), transferCode, completedTimestamp);
Review Comment:
No, i am just trying to learn as much about this before i can provide you my
review...
I have just found it weird, preparing a transfer and commit it has the very
same state...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
