Eyad-Sharkawy opened a new pull request, #6365: URL: https://github.com/apache/fineract/pull/6365
## Description Previously, the Entity Data Table Checks API (`/v1/entityDatatableChecks`) only returned the internal code/table name string for the `entity` field (e.g. `"m_client"`) instead of structured enum option data containing human-readable display values. This PR addresses [FINERACT-817](https://issues.apache.org/jira/browse/FINERACT-817) by: 1. Enhancing `EntityTables` enum with human-readable display labels and adding a `toEnumOptionData()` method that returns `StringEnumOptionData` (`id`, `code`, `value`). 2. Updating `EntityDataTableChecksData` to use `StringEnumOptionData` for the `entity` property instead of a raw `String`. 3. Updating `EntityDatatableChecksReadPlatformServiceImpl` to populate the `StringEnumOptionData` using `EntityTables.fromEntityName(entity).toEnumOptionData()`. 4. Updating the Swagger documentation in `EntityDatatableChecksApiResourceSwagger` to reflect `StringEnumOptionData entity`. 5. Adding unit tests in `EntityTablesTest` to verify enum option mapping and reverse lookup. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
