Aman-Mittal commented on PR #523:
URL:
https://github.com/apache/fineract-backoffice-ui/pull/523#issuecomment-5559265066
Pushed `b438c29e` for the 26 mocked-e2e failures. They were mine, and they
were pointing at something real about the fixtures.
Both branding suites served `branding/config.json` while the layer beneath
it said nothing. That is a state the container entrypoint cannot produce — it
sets `brandingOverlayEnabled` from the directory the deployer copied in — so
once the probe is gated on that flag, the fixtures were modelling a deployment
that shipped `branding/` and never told the application. They now declare it,
the way a real deployment does:
- `deployment-customization` derives it from whether the test asked for an
overlay at all, so the "no overlay mounted" cases keep exercising the off path.
- `branded-deployment` always mounts one, so it is always on.
Added the assertion this change is actually about, which only an e2e can
make:
```ts
test('does not ask for an overlay this deployment has not declared', async
({ page }) => {
const asked: string[] = [];
page.on('request', (r) => { if (r.url().includes('/branding/'))
asked.push(r.url()); });
await deployWith(page, null);
await expect(page.locator('.app-title')).toBeVisible();
expect(asked).toEqual([]);
});
```
A unit test cannot see this. It is about a request not being on the wire,
and the console entry it used to produce was written by the browser, not by us.
```
npx playwright test --project=mocked e2e/deployment-customization.spec.ts
e2e/branded-deployment.spec.ts
28 passed
```
### One local-only failure, for the record
A full `--project=mocked` run here came back `1 failed / 342 passed` on
`loan-servicing-gaps.spec.ts:203` — the interest-pause edit, whose Save button
stayed disabled because the form had not finished loading its dates.
It passes on its own, and it is a local artifact: this config uses `workers:
1` and `retries: 2` under CI but unbounded workers and no retries locally, so
my run was far more contended than CI ever is. Worth noting that the screen it
happens on is the one #513 is about — a form that races its own populating
request — so the test is inherently timing-sensitive until that is fixed.
Not touched here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
