Aman-Mittal commented on PR #526:
URL:
https://github.com/apache/fineract-backoffice-ui/pull/526#issuecomment-5560254998
Pushed `f8e5563f` for the GA readiness gate.
The blocking failure was mine: my new component spec built its fixture DOM
by assigning an HTML string, and `ga:check` treats that as a raw HTML sink
wherever it appears under `src/`. The gate is right — a test is not exempt from
a rule about sinks, and carving out an exception is an exception it would then
have to police.
The fixtures only ever needed an element with a class on it, so an `el()`
helper plus `append` does the same work. One thing worth mentioning because it
is an easy trap: my first attempt still failed, because the comment I wrote
explaining the fix *quoted* the sink it was avoiding, and the gate's pattern
matched the comment. It describes it instead now.
```
PASS No sanitizer bypasses or raw HTML sinks
8/9 gates pass; 0 blocking failure(s), 0 undetermined.
$ npm run ga:check; echo $?
0
```
The remaining line is the advisory adapter-boundary backlog at 323 call
sites, which this branch does not touch — `git diff apache/main...HEAD --
eslint-suppressions.json` is empty, and the count is read from that file.
Re-verified after the change: 237 files / 1454 tests, lint clean, prettier
clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
