Aman-Mittal commented on PR #526:
URL:
https://github.com/apache/fineract-backoffice-ui/pull/526#issuecomment-5560403214
Pushed `2cd49640` for the `feature-coverage.spec.ts` failure. It was not a
renamed string — the spec caught a real accessibility regression I had
introduced.
I had moved the long wording onto an `aria-label`. On a control that already
has visible text, `aria-label` **replaces** it as the accessible name, so the
button read "Guide" on screen and answered to "Open the guided tour for this
screen". That is WCAG 2.5.3 Label in Name: someone driving the page by voice
says "click Guide" and nothing happens.
`getByRole('button', { name: /Help Tour|Guide/ })` is precisely the check
for that, so the fix is on my side and the spec needs no change. The long
wording is a description now — `appTooltip` wires `aria-describedby` — and the
visible text is the accessible name again.
```
feature-coverage.spec.ts -g "help tour button" 1 passed
guidance-tour.spec.ts 5 passed
accessibility.spec.ts 3 passed
```
I ran `accessibility.spec.ts` as well because changing an accessible name
can shift the axe baseline fingerprints; it did not.
Worth noting for the record: this is the third defect in this branch found
by a check rather than by review — after Escape not working with focus outside
the card, and a tour surviving navigation. All three were in code I wrote, and
none was visible from reading the diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
