shubhamchaudhary29 opened a new pull request, #6453:
URL: https://github.com/apache/fineract/pull/6453

   ## Description
   
   The tax component API response contains `debitAccountType` and 
`debitAccount`, but these fields were missing from the OpenAPI/Swagger response 
documentation.
   
   I added the missing fields to the Swagger response model.
   
   ### Changes
   * Added `debitAccountType` to the response schema
   * Added `debitAccount` to the response schema
   * Added the required fields for both objects
   * Regenerated the OpenAPI specification
   
   ### Testing
   * Spotless check passed
   * Java compilation passed
   * OpenAPI generation passed
   * Verified that the generated OpenAPI schema contains the two new fields
   
   ## Checklist
   - [x] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [x] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [ ] Create/update [unit or integration 
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the 
changes made.
   - [x] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [x] Add required Swagger annotation and update API documentation
   - [x] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 Large changes can be made in a branch, with assistance.
   - [x] If merging this PR resolves a JIRA issue, I will mark that issue as 
resolved and set "Fix Version/s" appropriately.
   - [x] I followed the [AI 
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to