vidakovic commented on code in PR #6424:
URL: https://github.com/apache/fineract/pull/6424#discussion_r4023447109
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/config/cache/SpecifiedCacheSupportingCacheManager.java:
##########
@@ -49,7 +48,11 @@ public void afterPropertiesSet() throws Exception {
@Override
public Cache getCache(String name) {
- if (supportedCacheNames.contains(name)) {
+ boolean contains;
+ synchronized (supportedCacheNames) {
Review Comment:
I checked again, the only place where the cache names change is when
`setSupportedCaches` is called... and that happens only once during startup of
the application. From what I see the `synchronized` makes not much sense here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
